search

paullouisageneau / libdatachannel

C/C++ WebRTC network library featuring Data Channels, Media Transport, and WebSockets
https://libdatachannel.org/
Mozilla Public License 2.0
1.81k stars 366 forks source link

Is there a reason why this isn't a const std::string & ? #180

Closed Nemirtingas closed 4 years ago

Nemirtingas commented 4 years ago

Hi, is there a reason why in the ranged for its not a const ref ?

https://github.com/paullouisageneau/libdatachannel/blob/14f8858d3da2e92bbaea92969ecb408aba480671/src/candidate.cpp#L52

paullouisageneau commented 4 years ago

Indeed, there is no reason, this is definitely an oversight.

paullouisageneau commented 4 years ago

Changed in https://github.com/paullouisageneau/libdatachannel/commit/8cab2b9d879f5fbf5a2b44ee578f0b2fdcd4862d