Add juice_add_turn_server API

paullouisageneau / libjuice

JUICE is a UDP Interactive Connectivity Establishment library

Mozilla Public License 2.0

403 stars 75 forks source link

Closed Sean-Der closed 4 months ago

Sean-Der commented 4 months ago

Allows TURN servers to be added post agent creation

Sean-Der commented 4 months ago

Hey @paullouisageneau can I get another review please? I have addressed all the comments

thank you!

Sean-Der commented 4 months ago

@paullouisageneau can I get another review please! These two concerns are addressed/fixed

Don't realloc/modify the existing turn_servers. I didn't feel comfortable handling all the realloc failure cases. Now I malloc and copy into it, if that fails the existing turn_servers aren't edited
If the turn copy fails free the members