search

paulmach / orb

Types and utilities for working with 2d geometry in Golang
MIT License
886 stars 103 forks source link

Remove dependency on insecure crypto/md5 package #113

Closed pkumar0508 closed 1 year ago

pkumar0508 commented 1 year ago

crypto/sha256 is a suitable replacement as the standard library also provides it. This change only affects test code.

To be clear, I know this pull request looks a little silly, replacing a broken hash in one test. New dependencies on crypto/md5 have been disallowed in the codebase I'm trying to use github.com/paulmach/orb in. Given the change is small, easy, only affects test code, doesn't increase test runtime noticeably, and might resolve warnings about this dependency that other developers might run into, I figure I would send you a PR.

pkumar0508 commented 1 year ago

Thanks for #118 ! It satisfies my needs