paulmandal / atak-forwarder

Forwards packets to/from ATAK over an off-grid communication layer
MIT License
404 stars 42 forks source link

fix data type per issue #60 #61

Closed a-f-G-U-C closed 4 years ago

a-f-G-U-C commented 4 years ago

This PR fixes issue #60 by changing the plugin's packet type from CLEAR_TEXT (printable, or capable of being displayed on a screen with no further processing) to OPAQUE (just transport it from point A to point B with no other processing or content assumptions).

! WARNING - BREAKING CHANGE !

Since the packet type is currently used for packet selection, this change means that the messages from previous versions and future versions of the plugin will be incompatible and reciprocally ignored.

This should be managed via a documentation update and possibly a user notice.

a-f-G-U-C commented 4 years ago

this also keeps the Meshtastic app from creating notifications for ATAK Forwarder messages

Unfortunately the app still shows them in the chat screen, but at least it stops trying to display them as text. :)