search

paulmassen / grav-plugin-seo

Manage your site’s meta tags for display in search engine results or social media networks. Create and manage json-ld microdata. Includes an easy-to-use live preview feature.
MIT License
84 stars 21 forks source link

languages/en.yaml Duplicate key OUTOFSTOCK #104

Open npetri13 opened 2 years ago

npetri13 commented 2 years ago

I installed the plugin on Grav v1.7.26.1. Right after the install i've got a crickey error. I deleted the key 'OUTOFSTOCK' in the plugin's languages files, which makes the backend available again. The frontend wasn't affected at any time OUTOFSTOCK .

suterma commented 2 years ago

I got

500 - Failed to read en.yaml: Duplicate key "OUTOFSTOCK" detected at line 57 (near "OUTOFSTOCK: "Out of Stock"").

The site was permanently unavailable. Deleting the SEO plugin folder via the hosting company's backend brought the site back. I tried this twice, so this is not an accidential problem.

npetri13 commented 2 years ago

In my case only the backend wasn't available. The page itself was still working. As i said before, you may delete the OUTOFSTOCK - key in all language files and the plugin is working well. You find these language files in plugins/grav-plugin-seo/languages. There you will find three language files en.yaml, nl.yaml and ro.yaml. Just delete the key OUTOFSTOCK in all of these.

suterma commented 2 years ago

Thanks @npetri13 this worked well. I just removed the OUTOFSTOCK key in the en.yaml file, then removed all others, since I do not use these languages at all. The 500 got away immediately.

paulmassen commented 2 years ago

Thank you for this. It is quite urgent indeed for me to merge the PR about this.

I will try to release an update this week.

beamaria commented 2 years ago

Same problem here. Luckily I was able to delete the folder of the plugin and the website was ok after that. Please fix the error of this useful and nice plugin!!

markusritschel commented 1 year ago

Hi @paulmassen, Could you make these changes public in a new release? When installing the plugin one still runs into the error mentioned above. The current version 2.3.5 seems to be from 2018.

beamaria commented 1 year ago

@markusritschel I'm afraid the developer no longer updates this plugin. My question dates back to one year ago and never had a reply...

paulmassen commented 1 year ago

Hi, I cannot maintain this plugin but you are right that I should at least release the version without the bug.

I'm afraid this would drag new user and thus new problems, but maybe I can state this in the release note.

That said I highly recommend to use the official grav seo plugin instead of this one !

markusritschel commented 1 year ago

Hi @paulmassen, Thanks for the quick reply. Oh, that's a pity that you cannot maintain it anymore. I just stumbled upon the plugin today but from what I see it looks actually pretty useful and easy to use. Anyway, if you could release a new version without the bug, that would be great. Thanks!