paulmassen / grav-plugin-seo

Manage your site’s meta tags for display in search engine results or social media networks. Create and manage json-ld microdata. Includes an easy-to-use live preview feature.
MIT License
84 stars 21 forks source link

Removed duplicate OUTOFSTOCK key in language files #97

Closed EdgarMendoza closed 2 years ago

softyoda commented 3 years ago

Does SEO addon still in activity ? When i add it i have an error :

"Failed to read en.yaml: Duplicate key "OUTOFSTOCK" detected at line 57 (near "OUTOFSTOCK: "Out of Stock"")." on every pages of my site and admin pannel.

https://discourse.getgrav.org/t/grav-1-7-yamllinter-does-not-detect-failing-translation-files/16527

Is that normal ?

LuanHimmlisch commented 3 years ago

I had this problem many times so once it for all I was going to make an exact pull request This has been since Feb 22? Where is the maintainer @paulmassen ?

paulmassen commented 2 years ago

Sorry. I had no time to update the plugin...

I will try to take a look and make it compatible with Grav and Admin's latest version, but meanwhile I would recommend not using it...

LuanHimmlisch commented 2 years ago

@paulmassen the plugin works as a charm, it's by far the best SEO plugin, thanks a lot. This was the only error to my knowledge

aloxe commented 2 years ago

@paulmassen I second that. installed it on latest grav with a few different themes and I had no problem but the one fixed by this PR.

nnhthuan commented 2 years ago

Do not remove OUTOFSTOCK, just change it to OUT_OF_STOCK, then change the references in blueprints/seo.yaml

aloxe commented 2 years ago

@nnhthuan While the change you suggest fixes the bug it leaves an unused string for translators to maintain. Removing the duplicate is far simplier.