search

paulmaunders / delivery-slot-bot

A puppeteer based bot to monitor supermarket online delivery slots.
MIT License
54 stars 27 forks source link

Add an optional external browser configuration options #66

Closed andytson closed 4 years ago

andytson commented 4 years ago

browser_executable_path - Path to the chrome browser executable. If not supplied, the bundle installed Chromium will be used browser_launch_headless - Whether to run without a GUI window opening. If not supplied, treated as true browser_product - The browser to launch/connect to, one of chrome/firefox. If not supplied, treated as chrome

paulmaunders commented 4 years ago

I merged this in but it looks like it's not working. I think there's a typo in the variable name, but even when I fix that it doesn't seem like the config vars are making it through to the puppeteer launch function.

I've tried

executablePath: config.raw.browser_executable_path

but that doesn't seem to work either....

paulmaunders commented 4 years ago

Whoops, I think I've broken master now - I should really start testing pull requests before I merge them!