search

paulmcauley / klassy

Klassy is a highly customizable binary Window Decoration, Application Style and Global Theme plugin for recent versions of the KDE Plasma desktop.
691 stars 22 forks source link

Close button in Task Switcher is barely visible #131

Open eldar opened 4 months ago

eldar commented 4 months ago

Hey Paul!

Thanks for your great work on Klassy! I have just a small issue that's been nagging me: window close button in the Task Switcher in the dark mode is barely visible, as seen on this screencast: https://i.imgur.com/oMQw6SD.mp4 (imgur severely compressed the video, but you can still see it). The problem is that the cross symbol is a thin white on the dark background, and there is a thin blue outline when you hover the mouse over the button area. I think the problem here is that the body of the button is transparent. I am not a designer, but I would propose to remove transparency from the button, that is, you will not be able see through the window thumbnail under the button area. I do not have access to Windows/Mac right now to see how it's done there.

Regards, Eldar.

eldar commented 4 months ago

Screencast_20240409_072342.webm

Attaching the screencast directly.

paulmcauley commented 4 months ago

This seems to be an issue with the icons selected by whomever designed the task manager (part of Plasma, not Klassy). I don't know for sure, but they are likely using the window-close-symbolic icon rather than the window-close icon. In the Breeze icon theme I think these both have backgrounds. In Klassy they do not because window-close-symbolic should not have a background so that it can be used properly in GTK CSD titlebars and fake Kirigami window titlebars.

For example, Breeze window-close-symbolic close icon does not look correct in GTK CSD apps: shortwave

Whereas Klassy window-close-symbolic does look correct in GTK CSD: shortwave_klassy

There was a kde bug filed to change Breeze to remove the background, and I actually tried to make a merge request to implement this in Breeze in a consistent way so that it would also work with GTK titlebar (https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/212 ) but it seems that some KDE developers do not think this important and it has been largely ignored.

Maybe you can help by trying to push forward that merge request so that the Breeze close icons are implemented properly without the background on the symbolic version (Klassy can then be implemented the same way in terms of size) and maybe file a bug with the task switcher to use window-close rather than window-close-symbolic as well?

See also: https://github.com/paulmcauley/klassy/issues/124

paulmcauley commented 4 months ago

I also just mentioned this in discussion at: https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/349