paulmelnikow / AFNetworking-Synchronous

Synchronous requests for AFNetworking 1.x, 2.x, and 3.x
MIT License
162 stars 34 forks source link

AFNetworking 2.x support #3

Closed EliSchleifer closed 9 years ago

paulmelnikow commented 9 years ago

Hi, for sure! I'd be happy to integrate them.

EliSchleifer commented 9 years ago

Realizing while trying to put together the package that some definitions don't exist in AFNetworking 2.0 anymore. So we couldn't have the code live side by side unfortunately.

paulmelnikow commented 9 years ago

To keep it in one repository, maybe we could put the code in separate .[hm] files and use CocoaPods subspecs?

EliSchleifer commented 9 years ago

Interesting idea. Never made a subspec in cocoapods

On Fri, Oct 24, 2014 at 3:44 PM, Paul Melnikow notifications@github.com wrote:

To keep it in one repository, maybe we could put the code in separate .[hm] files and use CocoaPods subspecs http://guides.cocoapods.org/syntax/podspec.html#subspec?

— Reply to this email directly or view it on GitHub https://github.com/paulmelnikow/AFNetworking-Synchronous/issues/3#issuecomment-60439344 .

syrakozz commented 9 years ago

yes, it will be great if you can add your changes

paulmelnikow commented 9 years ago

@EliSchleifer Thanks so much for sharing this work back. I'd love to get this merged in and published since I think it will come in handy for a lot of people.

I pulled in the code from directr/AFNetworking-Synchronous into the afn2 branch (edit: now in master). Would you mind trying it out in your project and seeing if it works?

target 'AFNSync_Debug' do
  pod 'AFNetworking', "~> 2.0"
  pod 'AFNetworking-Synchronous/2.x', :git => 'https://github.com/paulmelnikow/AFNetworking-Synchronous', :branch => 'master'
end

By using subspecs, the 1.x and 2.x versions can coexist in the same repository.

paulmelnikow commented 9 years ago

If you get a chance to try this, let me know how you make out!

EliSchleifer commented 9 years ago

Hi Paul,

Sorry I didn't have a chance to look at this. Been kind of slammed and just moved.

On Sat, Jan 3, 2015 at 8:40 PM, Paul Melnikow notifications@github.com wrote:

If you get a chance to try this, let me know how you make out!

— Reply to this email directly or view it on GitHub https://github.com/paulmelnikow/AFNetworking-Synchronous/issues/3#issuecomment-68620864 .

paulmelnikow commented 9 years ago

No sweat!