Closed paulmillr closed 2 months ago
Hi @paulmillr
I can take a look at 1 to start.
@ben-polinsky great!
I'm new to Chokidar, but recently retired and looking for something to contribute to.
I'll be happy to look at code simplification and at least fix symlink bug https://github.com/paulmillr/chokidar/issues/967. I'm running into issues with that now with typed-css-modules
(PR for workaround).
@samuelneff nice
My first PR. 😄
Did all the tests work at some point? I've fixed two and am looking into a third breaking test.
should survive ENOENT for missing symlinks when followSymlinks:false
should watch symlinks within a watched dir as files when followSymlinks:false
should detect changes to symlink folders, even if they were deleted before
root_changed
event when the files inside the symlink are changed but this event isn't handled at all.I'll look into this one and the others next week. Please let me know if you want a PR for the ones I've worked on so far or if I should hold off until all are fixed.
please make a pr with everything at once. thanks.
@ben-polinsky Sorry I forgot you said you were going to look at CI tests. Have you had time to start yet? We can collaborate if you like. I've worked on the three mentioned above.
You can write to me directly if you prefer; sam@serndesign.com.
perhaps the best thing to do would be to open a pull request and add Samuel to the fork's collaborators
@samuelneff no problem at all. I only had some time this week to take a look at should survive ENOENT for missing symlinks when followSymlinks:false
and came to the same conclusion as you. Didn't test on older versions of node, but did test on both M1 and Intel macs (same result).
Happy to work on the DTS Linting issue if you haven't started.
We are looking for folks who are able to:
Any contributions are highly appreciated.