Fix filter pattern not being applied to files inside symlink subdirectories of the watched path

paulmillr / chokidar

Minimal and efficient cross-platform file watching library

https://paulmillr.com

MIT License

10.8k stars 574 forks source link

Fix filter pattern not being applied to files inside symlink subdirectories of the watched path #1307

Open samuelneff opened 6 months ago

samuelneff commented 6 months ago

This PR resolves issue #967 and applies the pattern filter to files nested inside symlinks.

No change in expected behavior or usage. New passing test added.

samuelneff commented 6 months ago

I'll address those issues, assuming they're real issues (lint at least probably is). 👍

samuelneff commented 6 months ago

@paulmillr It looks like none of the errors are actually related to my PR but are existing issues. This particular one is with DTS Lint and a missing function.

paulmillr commented 6 months ago

As i’ve mentioned, we can’t really merge new code unless we fix the old tests.

Otherwise some stuff could get broken and we wouldn’t even know.

Thanks for the pr.

samuelneff commented 6 months ago

Thanks for the update. I missed that specific message about the tests. I'll work on those next. 👍