search

paulmillr / chokidar

Minimal and efficient cross-platform file watching library
https://paulmillr.com
MIT License
10.8k stars 574 forks source link

test: switch to node test runner #1318

Closed 43081j closed 3 months ago

43081j commented 3 months ago

Switches to using the built-in node test runner and drops mocha.

Temporarily also introduces a TEST_TIMEOUT as --test-timeout is only available in 20.x and above, but we run CI in 18.x.

43081j commented 3 months ago

looks like tests are failing on windows quite often 😞

its late, ill have a look some other time soon

paulmillr commented 3 months ago

all good?

43081j commented 3 months ago

there's some flakiness/timing problem with the tests on windows when we use node's runner

i have a pretty hectic weekend but ill try pick it up soon and let you know

43081j commented 3 months ago

seems we have a passing test run!

on my fork, CI still fails every now and then for this test: https://github.com/43081j/chokidar/actions/runs/9337536632/job/25699552795#step:5:84

its a failed assertion rather than a timeout, so i will try investigate it more as the changeSpy definitely shouldn't have been called