paulmillr / chokidar

Minimal and efficient cross-platform file watching library
https://paulmillr.com
MIT License
10.8k stars 574 forks source link

feat: move to node:fs/promises #1329

Closed 43081j closed 2 months ago

43081j commented 2 months ago

Moves to using node:fs/promises rather than using promisify manually.

43081j commented 2 months ago

going to try fix this pesky windows failure while im in here 👍 lets not merge until i have, or i've given up 😂

paulmillr commented 2 months ago

@43081j can we make a list of whats needed for v4 in your opinion?

i want to ditch v3 bc i’m tired of ppl reporting “vulnerabilities”

43081j commented 2 months ago

@paulmillr sure ill try find some time this week to list whats left

the main blocker is this windows test, which im on the verge of fixing. almost certainly a timing issue in tests rather than anything wrong with the source

i can at least recreate it locally now, so will get around to fixing it eventually 👍

off the top of my head, the TLDR of whats left:

paulmillr commented 2 months ago

ok let's prepare for the release later this week.