Closed benmccann closed 2 months ago
Describe the bug
The index.d.ts file has:
index.d.ts
/** * Close watchers and remove all listeners from watched paths. * @returns {Promise<void>}. */ close(): Promise<void> | undefined;
Versions (please complete the following information):
To Reproduce:
Open index.d.ts
Expected behavior
Types and docs should match
Additional context
This prevents wrangler from upgrading because it expects a Promise<void> to be returned:
wrangler
Promise<void>
src/dev/use-esbuild.ts(226,4): error TS2322: Type '() => Promise<void> | undefined' is not assignable to type '() => Promise<void>'.
I think it should be Promise<void>
It may be worth annotating the return type in the source so we're certain it's always a promise (i.e to catch where we forgot to return one)
Describe the bug
The
index.d.ts
file has:Versions (please complete the following information):
To Reproduce:
Open
index.d.ts
Expected behavior
Types and docs should match
Additional context
This prevents
wrangler
from upgrading because it expects aPromise<void>
to be returned: