search

paulmillr / es6-shim

ECMAScript 6 compatibility shims for legacy JS engines
http://paulmillr.com
MIT License
3.11k stars 389 forks source link

make CI build faster #283

Closed PeterDaveHello closed 10 years ago

domenic commented 10 years ago

What does this do, and how can I learn of such tricks.

PeterDaveHello commented 10 years ago

it's for git's clone depth, defualt is 50 on travis CI, usually we don't use so much, smaller number can help clone faster, no doc yet, but have reference here : https://twitter.com/travisci/status/288390896339267584

mathiasbynens commented 10 years ago

Pretty sure detph is a typo

PeterDaveHello commented 10 years ago

Oh, yeah, sorry, let me fix it.

PeterDaveHello commented 10 years ago

fixed, thanks @mathiasbynens

ljharb commented 10 years ago

I'd prefer not to configure something that doesn't have a proven benefit. Can you provide comparisons that show a significant test speedup?

Without that, I'd prefer not to add configs we don't need.

PeterDaveHello commented 10 years ago

Just like we don't need the whole repo to CI build, do use git shallow clone, the default value of depth is 50 on travis CI, but usually we don't need so many revisions to build, a lower number can help to save the bandwidth and time.

ljharb commented 10 years ago

Since tests only take about 30 seconds to run, and bandwith is Travis' concern, I'd rather not add additional configuration that won't save a significant amount of time.

Thanks for the submission and the explanation!