search

paulmillr / es6-shim

ECMAScript 6 compatibility shims for legacy JS engines
http://paulmillr.com
MIT License
3.11k stars 389 forks source link

update year of Copyright (c) #317

Closed SerkanSipahi closed 9 years ago

ljharb commented 9 years ago

Thanks! Would you mind also updating the copyright year in es6-shim.js and es6-sham.js?

SerkanSipahi commented 9 years ago

i found one more updating file : es6-sham.min.js ! This repro is always maintained. I think it make sense for updating the copyright. It looks terrible if it is outdated !

SerkanSipahi commented 9 years ago

@ljharb : who has created this repro? the structure is not maintainable by the community ! who, what generated the min/map files, etc? why exists a node_modules directory? the "pull requests" make not sense at the moment !!! this repro should be cleaned up and restructured. Just README.md "pull request" is ok.

ljharb commented 9 years ago

@SerkanSipahi node_modules exists because that's where npm dependencies are installed, which every JS project uses. "Pull requests" are a github thing, and I'm not sure what you mean by "doesn't make sense".

The "min.js" files are automatically generated whenever the library is released and published on npm - github is just for development, npm is for consumption.

Also, I'm not sure that an out of date copyright year on an actively maintained project qualifies as "terrible" but thanks for your opinion.

SerkanSipahi commented 9 years ago

@ljharb what i mean is: i would hold clean the repro. Also, no node_modules folder, no min, map, etc files. If someone get this repro from npm or github it should have a build process where everything( node_modules, min, map, etc, information( e.g. copyright year ) ) are auto generated. I hope you know what i mean :)