paulmillr / es6-shim

ECMAScript 6 compatibility shims for legacy JS engines
http://paulmillr.com
MIT License
3.11k stars 387 forks source link

Chrome 41: `Math.asinh` and `Math.atanh` are imprecise #334

Closed ljharb closed 3 years ago

ljharb commented 9 years ago
var isAsinhOK = Math.asinh(0.0002) >= 0.0001999999986666666 &&  Math.asinh(0.0002) <= 0.0001999999986666668;
var isAtanhOK = Math.atanh(0.0002) >= 0.0002000000026666667 && Math.atanh(0.0002) <= 0.0002000000026666668;

Both of these are true in shimmed Firefox 37 and Safari 8, both false in Chrome 41 and Chrome Canary 44.

From https://github.com/kangax/compat-table/issues/392#issuecomment-92308965

ljharb commented 9 years ago

@Yaffle Note that our actual asinh and atanh shims fail this test also.

Yaffle commented 7 years ago

see https://github.com/kangax/compat-table/issues/392#issuecomment-240196072

anematode commented 3 years ago

It looks like this issue is fixed; probably should close the issue?

Yaffle commented 3 years ago

yes

ljharb commented 3 years ago

When (or in what PR/commit) was it fixed?

Yaffle commented 3 years ago

https://github.com/paulmillr/es6-shim/commit/ec76d49cb801a03fb0a98041e2bba190a41b8288

ljharb commented 3 years ago

Thanks!

Fixed in ec76d49, then.