search

paulmillr / es6-shim

ECMAScript 6 compatibility shims for legacy JS engines
http://paulmillr.com
MIT License
3.11k stars 387 forks source link

Silence Chrome webkitIndexedDB warning when es6-shim loads? #362

Closed mikemaccana closed 8 years ago

mikemaccana commented 8 years ago

blacklistedKeys.indexOf(k)

Throws up this warning when looking for webkitIndexedDB.

'webkitIndexedDB' is deprecated. Please use 'indexedDB' instead.

It's obviously not a real error, and there's nothing wrong with es6-shim, because it's checking for blacklistedKeys. But Is there any way we can silence it?

mikemaccana commented 8 years ago

This also applies to:

'window.webkitStorageInfo' is deprecated. Please use 'navigator.webkitTemporaryStorage' or 'navigator.webkitPersistentStorage'

ljharb commented 8 years ago

Thanks for the report! This is actually an https://github.com/es-shims/es5-shim issue, would you mind filing it there?

ljharb commented 8 years ago

(also, in the latest es5-shim, this may have been resolved already - it's not doing an indexOf anymore, it's doing an object lookup to a local cache)

mikemaccana commented 8 years ago

Thanks for the quick reply @ljharb! Since it's fixed in es5-shim, maybe it's worth bumping the version of es5-shim that es6-shim requires?

ljharb commented 8 years ago

It's only required in tests, not as a runtime dependency - and since it's required with ^ ranges, it should pull in automatically.