search

paulmillr / es6-shim

ECMAScript 6 compatibility shims for legacy JS engines
http://paulmillr.com
MIT License
3.11k stars 387 forks source link

Set missing forEach method on Firefox 24 #421

Closed mockdeep closed 7 years ago

mockdeep commented 7 years ago

Looks similar to https://github.com/paulmillr/es6-shim/issues/143, but using Lodash on Firefox 24 results in an error: TypeError: set.forEach is not a function. Looks like Set is defined, but doesn't implement forEach.

ljharb commented 7 years ago

Can you make a jsfiddle that reproduces the issue?

mockdeep commented 7 years ago

Sure, there's not much to it: https://jsfiddle.net/dgswvqc7/

ljharb commented 7 years ago

Ideally one that includes es6-shim :-)

mockdeep commented 7 years ago

Hmm, it seems to work with the jsfiddle, so I guess it must be on my end. Let me verify that the shims are included properly.

mockdeep commented 7 years ago

Doh! Turns out I had included es6-sham instead of es6-shim. It's all working now.

ljharb commented 7 years ago

es6-sham requires es6-shim first be included. Glad you figured it out and thanks for the followup!