search

paulmillr / es6-shim

ECMAScript 6 compatibility shims for legacy JS engines
http://paulmillr.com
MIT License
3.11k stars 387 forks source link

set/get ngFor performance on IE11 #422

Closed aronallen closed 7 years ago

aronallen commented 7 years ago

Hi,

We are having this issue in Angular 2 land. Any chance shim performance can be improved for IE11.

https://github.com/angular/angular/issues/8112

The code is constantly calling isNan function in es6-shim.js. The problem seems to be due to the reason that set and get functions of the polyfill are extremely slow (compared to their native counterparts) and take most of the time.

ljharb commented 7 years ago

I'd be happy to improve performance wherever it can be done without sacrificing correctness.

I'm not sure what the best way to do that is, but am open to PRs.

jdalton commented 7 years ago

I'll give a PR a try :grinning: (#429)

ljharb commented 7 years ago

@aronallen #429 is released with v0.35.2 - please let me know if that does not resolve your performance issue.