search

paulmillr / es6-shim

ECMAScript 6 compatibility shims for legacy JS engines
http://paulmillr.com
MIT License
3.11k stars 387 forks source link

Unneeded argument for overrideNative #456

Closed lukastaegert closed 3 years ago

lukastaegert commented 5 years ago

Here and in the following lines, Rollup considers the final argument true to overrideNative to be superfluous, to which I agree looking at the definition.

https://github.com/paulmillr/es6-shim/blob/b5cca2ad271a7f9c80a7bfea4d05f875c80dd400/es6-shim.js#L1319

https://github.com/paulmillr/es6-shim/blob/b5cca2ad271a7f9c80a7bfea4d05f875c80dd400/es6-shim.js#L267

Is this correct?

ljharb commented 5 years ago

Indeed you're right, I'm not sure why those pass a 4th argument.

ljharb commented 3 years ago

Fixed in 276c60c.