EdDSA: add validate-after-sign

paulmillr / noble-curves

Audited & minimal JS implementation of elliptic curve cryptography.

https://paulmillr.com/noble

MIT License

621 stars 56 forks source link

EdDSA: add validate-after-sign #106

Open paulmillr opened 6 months ago

paulmillr commented 6 months ago

https://github.com/openpgpjs/noble-curves/commit/559e53c4293d9f858e2fa74502c1c37fba6a90b5

@larabr a pr would be highly appreciated!

larabr commented 6 months ago

Sure, I can open it. FWIW we are still gathering some stats to understand if this sort of bitflips do happen in the wild. Let me know if you want to add this feature regardless 👌

paulmillr commented 6 months ago

It's only few lines of code - seems useful "just in case".

larabr commented 3 months ago

(Sorry but I haven't gotten around to opening the PR yet).

FYI there is now an RFC draft about non-deterministic EdDSA signature to tackle the underlying issue: https://datatracker.ietf.org/doc/html/draft-irtf-cfrg-det-sigs-with-noise-03 . I think implementing that variant is probs a better solution for people who do not care about the deterministic result 🙂