search

paulmillr / noble-curves

Audited & minimal JS implementation of elliptic curve cryptography.
https://paulmillr.com/noble
MIT License
664 stars 62 forks source link

Support groestl #19

Closed gruve-p closed 1 year ago

gruve-p commented 1 year ago

Groestl was a sha-3 candidate: https://github.com/Groestlcoin/groestl-hash-js

Reasons we want groestl added on noble-hashes:

  1. We have our own bip32 fork. Recently you send a PR and we no longer can merge the changes from upstream without getting on noble-hashes first.
  2. We have our own wif fork. Recently you send a PR and we no longer will be able to merge the changes from upstream without getting on noble-hashes first.
  3. We have our own bs58check fork. Recently you send a PR and we no longer can merge the changes from upstream.
  4. We have our own bitcoinjs-lib fork. Recently you send a PR and we no longer can merge the changes from upstream.
paulmillr commented 1 year ago

If you maintain this many forks, you could fork noble-hashes and add groestl to your fork.

What's the benefit for noble of using hash no one uses?

I am obviously not obligated to write any new code, even if your projects got broken. This is project that's being developed for free in my spare time. Benefits of upgrading Bitcoin lib users to noble are big.