Allow long seed behind noCheckLength flag

paulmillr / noble-curves

Audited & minimal JS implementation of elliptic curve cryptography.

https://paulmillr.com/noble

MIT License

623 stars 56 forks source link

Allow long seed behind noCheckLength flag #54

Closed mahnunchik closed 1 year ago

mahnunchik commented 1 year ago

I need this feature to be able to use 64 bytes seed as private key.

Test added
Fixed test for invalid private key

paulmillr commented 1 year ago

Every other library, besides Elliptic (which has faulty ed25519), does not support this. Why, do you think, we should add the feature?

paulmillr commented 1 year ago

We can't merge a feature like this, unless there are a lot of users. It's sad that elliptic used the non-compliant method, but we can't copy its bugs.

https://docs.rs/ed25519-dalek/latest/ed25519_dalek/struct.SecretKey.html

mahnunchik commented 1 year ago

I decided to fork noble-ed25519 to suit my needs https://github.com/CoinSpace/noble-ed25519/commit/109f22012f6f65b242a16529620b9cf70b1aed58