paulmillr / noble-curves

Audited & minimal JS implementation of elliptic curve cryptography.
https://paulmillr.com/noble
MIT License
623 stars 56 forks source link

Add decaf448 #59

Closed stknob closed 1 year ago

stknob commented 1 year ago

Based on draft-irtf-cfrg-ristretto255-decaf448-07, draft-irtf-cfrg-hash-to-curve-16 and the ristretto255 implementation.

sublimator commented 1 year ago

nice :)

paulmillr commented 1 year ago

This is great!

paulmillr commented 1 year ago

Tests seem to be failing.

stknob commented 1 year ago

Tests seem to be failing.

Forgot to run prettier on the files, should be fixed now.

paulmillr commented 1 year ago

Add benchmarks please and we're good to go.

paulmillr commented 1 year ago

Also, README docs.

paulmillr commented 1 year ago

Thanks!

In the future, please don't force-push: this requires me to re-review all files for the second time, instead of just watching new/diff commits.

If you wanted to ensure history cleanliness, it's good, but no need: I can always squash-merge a PR if it gets too messy.

sublimator commented 1 year ago

Nice! can use this for voprf