paulmillr / noble-ed25519

Fastest 4KB JS implementation of ed25519 signatures
https://paulmillr.com/noble
MIT License
420 stars 51 forks source link

Wrong signature with version > 1.60 #70

Closed joepio closed 2 years ago

joepio commented 2 years ago

Hi there! Thanks for building / maintaining this.

So today I noticed that my newly published library created wrong signatures. After trying some things, the problem was fixed by locking my noble-ed25519 version to v1.6.0. I'm not entirely sure what that means, but all I know is that bumping this version suddenly leads to getting wrong signatures.

Here's the codesandbox where things went wrong.

Edit: But I haven't been able to reproduce the issue in a different codesandbox using only noble-ed25519. Doesn't look like it's this repos fault, then! So maybe it was a bitflip during compiling the JS files? Divine intervention? Maybe I'll never know.