Closed jeetiss closed 1 year ago
run big-endian check in every entry and mark it as sideEffect
why? does sideEffects: false in package.json help us in any way? i've thought only PURE annotations do.
sideEffects: false
allows to webpack skip unused imports earlier and not traverse over all module treesideEffects: false
decrease the bundle size for all entries ~100B-300B
made a little demo with stackblitz to test that behavior
@paulmillr Hello,
Are you interested in those changes? I wanna create some PR for the curves
package.
@jeetiss thanks for the pull request. It's good. Yes, I am interested.
I am concerned with moving-out big-endian
check into the separate file.
It's always used. Can't we just keep it in utils? I assume sideEffects: false remove it, but what else do they remove?
Please don't make curves PR until we merge the current one, don't want you to do work that won't be merged.
I think it should be better to split this PR into a couple:
sideEffects: false
The first two are not so controversial and we can discuss options for sideEffects
after
I applied some optimizations to reduce bundle size:
sideEffects: false
to improve dead code elimination_u64
_assert
and_u64
module to wildcard imports to enable tree-shaking/*#__PURE__*/
annotation to all top-level invocationssizes (with all dependencies, minified and gzipped):
i used #62 to test changes