Benchmarks are slowed down when other modules are imported - Githubissues

paulmillr / noble-hashes

Audited & minimal JS implementation of hash functions, MACs and KDFs.

https://paulmillr.com/noble

MIT License

545 stars 46 forks source link

Benchmarks are slowed down when other modules are imported #91

Open paulmillr opened 2 months ago

paulmillr commented 2 months ago

I've spotted this after benchmarks were transitioned from common.js to ESM in 88c1aa30674348f497f936e497d734a15f53be26. Check out main branch.

git clone git@github.com:paulmillr/noble-hashes.git && cd noble-hashes && npm install && npm run build && npm run bench:install
Comment-out lines 14-28 in benchmark/hashes.js, run again. sha3 would become 25% faster

We need to investigate:

Why sha3 is 25% slower when other modules are imported
Why sha2 is NOT slower when other modules are imported. What's special about sha3?
Why everything was fine with common.js, but is slow with ESM?
Bonus issue: re-exporting isBytes slows-down performance considerably. See branch https://github.com/paulmillr/noble-hashes/tree/import-perf. Probably related.

To investigate this, v8/node.js profiling, memory dumps, etc may help.