Feature: Refactor this to use fs.openDir in future and not fs.readdir

[frank-dspeed]

NodeJS > 12.11.1 will have async readdir support Landed in cbd8d71 ( nodejs/node@cbd8d71 ) as fs{Promises}.opendir(), which returns an fs.Dir, which exposes an async iterator.

to stay compatible we could implament it with the same stream interface and simply check if fs.openDir is there if not fallback to existing implamentation.

This is a lobby Request <3 by the microsoft/vscode community

• https://github.com/microsoft/vscode/issues/82116

[paulmillr]

easy

[paulmillr]

See branch v4 for implementation: https://github.com/paulmillr/readdirp/tree/v4

Execute node examples/list, ensure to pass big directory there.

1. v4 branch ditches readable stream in favor of async generators (node 10+).
2. This allows to speed-up a file tree of 45k entries from 1.6 sec to 500ms (3x).
3. opendir works, you'll need node 12.12, it's 3x slower than readdir — MEH! It's as slow as current readdirp-v3.

[yisibl]

Hi, @paulmillr Why is opendir slower instead?

[paulmillr]

@yisibl ?

[yisibl]

opendir works, you'll need node 12.12, it's 3x slower than readdir — MEH! It's as slow as current readdirp-v3.

[paulmillr]

What is the question? Open dir is 3x slower. Why is it slower? I don't know. Shitty node.js implementation.