search

paulmillr / readdirp

Recursive version of fs.readdir with streaming api.
https://paulmillr.com
MIT License
378 stars 51 forks source link

npm install warning #123

Closed XhmikosR closed 3 years ago

XhmikosR commented 4 years ago

It seems typescript is missing from devDependencies?

https://github.com/paulmillr/readdirp/runs/272245666#step:4:6

XhmikosR commented 4 years ago

BTW this is the slowest part on CI; dtslint downloads all types every time.

paulmillr commented 4 years ago

Yeah, that’s why I don’t like it.

paulmillr commented 4 years ago

Perhaps we do dtslint only when the file was changed, or something like that. Or on release only.

XhmikosR commented 4 years ago

But then it means that a release would have been made and it might have broken types.

Unless you follow a specific branch scheme before releases, say release-* or similar, then we could run it separately. Still, since I'm not familiar with dtslint, I'm not sure if we need to add typescript to devDependencies.