search

paulmillr / readdirp

Recursive version of fs.readdir with streaming api.
https://paulmillr.com
MIT License
378 stars 51 forks source link

dtslint updates #126

Closed XhmikosR closed 4 years ago

XhmikosR commented 4 years ago

Instead run it once, only on Node.js 12 and on Ubuntu.

XhmikosR commented 4 years ago

I'm thinking maybe we should move dtslint to a separate action?

XhmikosR commented 4 years ago

@paulmillr let me know what you prefer and I'll rebase this. I also renamed the matrix node-version to node since it's shorter.

EDIT: we could even remove dtslint from the devDependencies and just run npx dtslint. Since the node modules aren't cached anyway

XhmikosR commented 4 years ago

It's still just too slow... It's better than before since the other workflows finish on 1/4 of the time.

But dtslint still has to download all the types for all versions (also has 92 dependencies). Maybe there's a way to tweak its behavior? I'm not familiar with dtslint at all myself. Or maybe there's another package we should use.

Either way, when we have caching on Actions, this won't be a problem for subsequent runs.

I also tried installing dtslint globally on CI and then run it, but it didn't work.

paulmillr commented 4 years ago

Let’s reduce the amount of versions it downloads to maybe 4 most recent.

XhmikosR commented 4 years ago

I'm not sure how to do that :P

XhmikosR commented 4 years ago

I think it still makes sense to have dtslint as a separate action. When we have caching in actions, we can cache dtslint download folder and this will be a lot faster, hopefully.

I'll do the same for chokidar, if this lands.

paulmillr commented 4 years ago

prob a good idea to make this a sub-job of lint category? similar to eslint

XhmikosR commented 4 years ago

I can move eslint and dtslint to a "Lint" action, if you prefer that. And only run it for Node.js 12

XhmikosR commented 4 years ago

Pushed. Do note that there's a limit in concurrent actions (I think it's 16)