Doesn't follow symbolic link to directories

paulmillr / readdirp

Recursive version of fs.readdir with streaming api.

https://paulmillr.com

MIT License

381 stars 52 forks source link

Doesn't follow symbolic link to directories #150

Closed znarf closed 4 years ago

znarf commented 4 years ago

Currently, the library is properly following symbolic link to files but it's not properly following symbolic link to directories.

It's considering any symbolic link as files: https://github.com/paulmillr/readdirp/blob/master/index.js#L202

bpasero commented 4 years ago

@znarf @paulmillr trying to understand the consequence of this change for chokidar (because I am thinking to update for VSCode): I just verified that I see file events (on macOS) for a symlinked folder when I change files within even with an older version of chokidar, so it seems to me that chokidar always supported this? Then I do not understand what impact this change has on chokidar?