search

paulmillr / readdirp

Recursive version of fs.readdir with streaming api.
https://paulmillr.com
MIT License
381 stars 51 forks source link

Create .npmignore #55

Closed eugenelim closed 6 years ago

eugenelim commented 6 years ago

Remove test/ folder from being published with the npm package

thlorenz commented 6 years ago

Please show that this makes a meaningful difference, i.e. only if the tarball is significantly smaller will I consider the pull, otherwise not since for some people working offline it is important to access the tests as part of the packages they installed locally on their machine.

You can compare the sizes as follows:

git checkout master
npm pack
du -h *.tgz

git checkout <your-branch>
npm pack
du -h *.tgz
paulmillr commented 6 years ago

Decided to go ahead with that in bdac11df.

It reduces the package size twice (13kb -> 7kb), which saves about 6000*3500000/(1024**3) 19Gb of traffic every week for NPM users.