paulmillr / readdirp

Recursive version of fs.readdir with streaming api.
https://paulmillr.com
MIT License
381 stars 51 forks source link

bad release v3.0.1 #90

Closed Roms1383 closed 5 years ago

Roms1383 commented 5 years ago

Hi @paulmillr I think you have a problem on your latest release 3.0.1 and some others :

currently on your master's index.js the part of the code where the directoryFilter is evaluated is correct :

Screen Shot 2562-06-02 at 23 31 23

as in the method normalizeFilter, all negative should use negative.some instead of negative.every (I tested it locally).

but when installing several releases from NPM (so far I've tried 3.0.1, 3.0.0 and 2.0.1) the code installed contains negative.every, causing the directoryFilter to only work with a single entry (e.g. ['!.git']), while failing with many entries (e.g. ['!.git', '!node_modules']).

Screen Shot 2562-06-02 at 23 45 21

I can't open a PR as your code on master is correct, it looks like it's more a problem happening on releasing.

Hope this helps 😊

Roms1383 commented 5 years ago

p.s : it's also related to my comment here

paulmillr commented 5 years ago

pushed