Closed mahnunchik closed 8 months ago
@mahnunchik all good with regards to the port itself?
@paulmillr I'm working on it.
It was right idea to have separate module because I've to reuse btc-signer
for legacy normal addresses.
If something doesn't work, please prepare a pr with all needed changes to make it work, so we can put it into one version: I don't want to release many scure-base releases in a row.
When I ported it to CashAddr, I noticed some points that could be made clearer:
_words
variable name because the same name is used in the upper scope.data
name matches with the error message.lowered
to function parameterstr
for readability and originalstr
in error message.