search

paulmillr / scure-base

Secure, audited & 0-deps implementation of bech32, base64, base32, base16 & base58
https://paulmillr.com/noble/#scure
MIT License
106 stars 13 forks source link

Wrong usage of `/* @__PURE__ */` annotation #31

Closed martines3000 closed 5 months ago

martines3000 commented 5 months ago

Hi.

I am not sure if this a bug, but I still want to mention it in case it is.

Rollup throws this warning: image

For this part of the code: https://github.com/paulmillr/scure-base/blob/713480919ce9643cdf1a89ddbfb8e0f40dea87e4/index.ts#L412

It probably should be /* @__NO_SIDE_EFFECTS__ */ instead, right ?

Thank you.

paulmillr commented 5 months ago

yes

rasgo-cc commented 2 months ago

@paulmillr any chance we could get this into 1.1.7 soon? :)

paulmillr commented 2 months ago

it would be great if we'd get https://github.com/paulmillr/scure-base/pull/34 into 1.1.7 in, but we'll need tests for that. Any chance you could add them? @rasgo-cc