I'm wondering if the salt() should be transforming the passphrase by prepending "mnemonic"?
const salt = (passphrase: string) => nfkd(`mnemonic${passphrase}`);
As far as I can tell this is undocumented, and could catch developers unawares, if they haven't dived in to the code, creating a passphrase different to what they expect.
Some ideas I've had for possible alternatives:
fallback if no passphrase is provided
force a passphrase to be provided
provide a separate function that uses the exact password given
Great library, really appreciate your work!
I'm wondering if the
salt()
should be transforming the passphrase by prepending "mnemonic"?As far as I can tell this is undocumented, and could catch developers unawares, if they haven't dived in to the code, creating a passphrase different to what they expect.
Some ideas I've had for possible alternatives:
Happy to make a PR if it helps :)