Bug: incorrect weight estimation for wph, wsh, and tr transactions

[mahnunchik]

Incorrect weight estimation for wph, wsh, and tr transactions.

import * as btc from '@scure/btc-signer';
import assert from 'assert/strict';
import bitcoinjs from 'bitcoinjs-lib';
import { hex } from '@scure/base';
import { secp256k1 } from '@noble/curves/secp256k1';

const privKey = hex.decode('0101010101010101010101010101010101010101010101010101010101010101');
const txP2WPKH = new btc.Transaction();
txP2WPKH.addInput({
  txid: '0101010101010101010101010101010101010101010101010101010101010101',
  index: 0,
  witnessUtxo: {
    amount: 1234567890n,
    script: btc.p2wpkh(secp256k1.getPublicKey(privKey, true)).script,
  },
});

txP2WPKH.addOutputAddress(btc.p2wpkh(secp256k1.getPublicKey(privKey, true)).address, 1n);

txP2WPKH.sign(privKey);
txP2WPKH.finalize();

// 274 !== 438
assert.equal(txP2WPKH.weight, bitcoinjs.Transaction.fromHex(txP2WPKH.hex).weight());

[mahnunchik]

There are tests for weight https://github.com/paulmillr/scure-btc-signer/blob/main/test/bitcoinjs-test/btcjs.test.js#L29 but it seems they are false positive.

[mahnunchik]

Could you please clarify the ETA for the next release?

[paulmillr]

should be coming any minute