search

paulmillr / scure-btc-signer

Audited & minimal library for creating, signing & decoding Bitcoin transactions.
https://paulmillr.com/noble/#scure
MIT License
151 stars 39 forks source link

make preimageWitness* methods public #61

Closed huckym closed 9 months ago

huckym commented 11 months ago

@paulmillr Is there a good reason why these methods are private? We are building an offline hardware wallet where this library is used for transaction creation, and creating the hashes that the offline hardware will sign. This library will then updateInputs and finally submit transactions. Currently we are forced to import dynamically so typescript doesn't complain that we are using a private method. Would hate to maintain a fork just for this.

paulmillr commented 11 months ago

reason was lack of use cases, but your case sounds solid, so we can expose it

huckym commented 11 months ago

Awesome! Thanks so much.