search

paulo-fernando-silva / vscOctaveDebugger

MIT License
35 stars 4 forks source link

can't set breakpoints in VSCode 1.28.2 #16

Closed davydden closed 5 years ago

davydden commented 5 years ago

I can't set breakpoints in VSCode 1.28.2 and macOS Mojave 10.14.1.

@PeterEnis1234 writes in original issue

Same problem on Windows

so it looks like it's not OS specific.

simple gif to demonstrate it on a project with 2 files:

/c++
/c++/hallo.c
/octave
/octave/hallo.m

octave_breakpoints

paulo-fernando-silva commented 5 years ago

Hm, in my case it works. I have a similar project, and I can place breakpoints on both. Can you set "trace": true in your matlab project's launch.json, run the test program and post the "DEBUG CONSOLE" output here?

The only way I'm able to replicate that is if I deactivate the plugin. But in that case you shouldn't even be able to create a launch.json or launch a matlab session.

paulo-fernando-silva commented 5 years ago

I think I know the issue. Your language is set to Octave, while the plugin expects it to be MATLAB. Can you change and test? Say, add "files.associations": {"*.m": "matlab"}, to your settings.json.

davydden commented 5 years ago

the plugin expects it to be MATLAB.

I have Octave plugin installed which adds syntax highlighting for octave.

Is this a limitation from VSCode that you need to support only one type of association (i.e. MATLAB file or Octave)? If not, I would suggest to support both. From user perspective, it's quite confusing that octave debugger plugin needs .m files to be associated with Matlab.

Can you change and test?

If I install Matlab language support plugin, then the debugger works indeed.

Presumably that's what you use. But this should certainly be documented because without any extra plugin VSCode won't be able to associate .m with neither Octave nor Matlab.

paulo-fernando-silva commented 5 years ago

The issue is that I didn't even know there was an octave language extension I believe. Besides the matlab extension has cuter icons. Nevertheless I modified the package.json to add matlab and octave language support even without the extensions. But I do suggest them in the readme now.

This is fixed in v0.2.4. Test it and let me know if we can close this issue.

davydden commented 5 years ago

@paulo-fernando-silva

This is fixed in v0.2.4. Test it and let me know if we can close this issue.

thanks a lot, really appreciate it! 👍

My VSCode has not realized yet that there was an update, so I will test ASAP, but for now closing this issue.