search

paulo-hortelan / requests-graph-pulse

A Laravel Pulse package that allows you to view the requests over time in a graph
MIT License
17 stars 4 forks source link

[Feature Request]: Show number of request on hover #8

Closed jhm-ciberman closed 3 months ago

jhm-ciberman commented 6 months ago

What happened?

I just deployed this awesome package to production, and it is great! Thanks for the amazing work.

I would like to request if it would be possible to show the number of requests when hovering the mouse. Currently only the max value is shown:

image

Other native charts like the Queues chart or the memory usage chart do display the number when hovering:

image

How to reproduce the bug

.

Package Version

1.1

PHP Version

8.3

Laravel Version

11

Which operating systems does with happen with?

No response

Notes

No response

paulo-hortelan commented 6 months ago

Hello and thank you for using my package.

This feature already exists and it's working properly on my projects:

image

However I'm using only Laravel 10, so maybe this is a bug for Laravel 11.

I'll try to reproduce and fix it, but PR are always welcome. Thank you for reporting

jhm-ciberman commented 6 months ago

Oh, weird. for me it shows only the number of non 2XX requests:

image

This is my artisan about in my prod environment:

forge@XXXXXXXXXX:~/XXXXXXXXX$ php artisan about

  Environment ........................................................................................................
  Application Name ........................................................................................ XXXXXXXXX
  Laravel Version ............................................................................................. 11.6.0
  PHP Version ................................................................... 8.3.3-1+ubuntu22.04.1+deb.sury.org+1
  Composer Version ............................................................................................. 2.7.6
  Environment ............................................................................................. production
  Debug Mode ..................................................................................................... OFF
  URL ............................................................................................. XXXXXXXXXX
  Maintenance Mode ............................................................................................... OFF

  Cache ..............................................................................................................
  Config ...................................................................................................... CACHED
  Events ...................................................................................................... CACHED
  Routes ...................................................................................................... CACHED
  Views ....................................................................................................... CACHED

  Drivers ............................................................................................................
  Broadcasting .................................................................................................. null
  Cache ........................................................................................................ redis
  Database ..................................................................................................... pgsql
  Logs ......................................................................................................... daily
  Mail ...................................................................................................... postmark
  Queue ........................................................................................................ redis
  Session ....................................................................................................... file

  Pulse ..............................................................................................................
  Enabled .................................................................................................... ENABLED
  Version .............................................................................................. v1.0.0-beta16

  Livewire ...........................................................................................................
  Livewire ................................................................................................... v3.4.10
jhm-ciberman commented 6 months ago

I'm wondering. Could it be that numbers greater than 100 are not shown?

paulo-hortelan commented 6 months ago

Don't think so, in my production environment on the last 7 days we have this:

image

Can you create the same scenario using Laravel 10 instead of the 11?

maciek-szn commented 3 months ago

I'm wondering. Could it be that numbers greater than 100 are not shown?

I see this issue with values over 10000.

obraz

obraz