paulo-raca / YetAnotherArduinoPcIntLibrary

An Arduino library to handle Pin Change Interrupts
21 stars 5 forks source link

Support for ATTiny1634 #1

Open colesnicov opened 6 years ago

colesnicov commented 6 years ago

Hello. I would like to implement support for ATTiny1634. I wonder whether it will be enough in the "PinChangeInterruptBoards.h" defined as follows:

#elif defined(__AVR_ATtiny1634__)
// 1634, special 3 port case
#define PCINT_INPUT_PORT0 PINA // PCINT0 - PCINT7
#define PCINT_INPUT_PORT1 PINB // PCINT8 - PCINT11
#define PCINT_INPUT_PORT2 PINC // PCINT12 - PCINT17

?

paulo-raca commented 6 years ago

I'm not familiar with this specific chip, but that's probably it.

If you have any issues, double check if the mapping is consistent with the implementation of these methods: digitalPinToPCICR digitalPinToPCMSK digitalPinToPCICRbit digitalPinToPCMSKbit

colesnicov commented 6 years ago

Because I use "ATTinyCore" from "@SpenceConde" so I would mention it to him, these macros that you have highlighted are part of the arduino core that keeps him. I'll leave it for now, I'll use the train to check the status of the pin. Or maybe I will add it here ..