search

paulocheque / django-dynamic-fixture

A complete library to create dynamic model instances for testing purposes.
http://django-dynamic-fixture.readthedocs.io/
Other
391 stars 67 forks source link

Fixed importing FieldDoesNotExist exception class for Django==3.1 #134

Closed DrMartiner closed 3 years ago

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling eae3356d57e33c85d7bc55c00b2a694295d23084 on DrMartiner:master into 657d9b0af6418bffd97d76cc784fb2b9a2f8f9a0 on paulocheque:master.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling eae3356d57e33c85d7bc55c00b2a694295d23084 on DrMartiner:master into 657d9b0af6418bffd97d76cc784fb2b9a2f8f9a0 on paulocheque:master.

jheld commented 4 years ago

@paulocheque can you please review this soon? Django twilio (release: https://github.com/rdegges/django-twilio/releases/tag/v0.13.1.b1) also needs this fixed because this repo is a dependency in the test runner; the tests are breaking, and hopefully we can get this resolved in short order.

uhurusurfa commented 4 years ago

@paulocheque - adding to the requests above. Great app you have built and would be good to get this merged.

pkasemir commented 4 years ago

@paulocheque Can you merge this?

clearyusc commented 4 years ago

Please merge!

s-i-l-k-e commented 4 years ago

@paulocheque how is this progressing?

uhurusurfa commented 4 years ago

Anyone interested in being a member on a fork of this project until such time as Paulo decides to allow more developers to help him so that this type of scenario does not happen again? That way we can provide timely solutions as Django evolves and not stall other projects that use this one. If and when Paulo decides to actively develop this app with more (trusted) people allowed to review and merge code fixes thus eliminating the scenario we find ourselves in then we can merge back in?

RaddishIoW commented 4 years ago

I'm up for helping on the fork. This is preventing me from updating to 3.1 - the only thing preventing me from updating.

RaddishIoW commented 4 years ago

@paulocheque committed a change to the Readme 10 days ago, so he's definitely still active on the project. Just a shame he hasn't approved this pull request yet. He might not have seen it I guess, but maybe he needs some other people approved to help out on GitHub?

jheld commented 4 years ago

While at it, can you open an issue for PyPI ownership transfer? It may take some time, but since he has been uncommunicative despite some recent activity, having a fork and PyPI will make this seamless for users long-term.

@paulocheque We understand, life gets busy, all sorts of things happen (and we appreciate the work you have done); but making changes while ignoring critical updates provided by the community, do leave some folks with frustration.

iamjstates commented 4 years ago

Merging this would be greatly appreciated

vecchp commented 4 years ago

Hi, this issue is also showing up as a blocker for https://github.com/saxix/django-adminactions/pull/173. Any way we can move this forward?

jheld commented 4 years ago

You can open up an issue for PyPI ownership.

paulocheque commented 3 years ago

Hello guys, I was really away and I wasn't expect such critical demand right now. I am really sorry for the delay. I will put you guys as collaborators of the project, ok?

And I merged this and I will generate a new version with this fix.

paulocheque commented 3 years ago

Version 3.1.1. released with this PR!

RaddishIoW commented 3 years ago

@paulocheque Thank you for this - I (and I'm sure everyone else) appreciate the work you've done on this project. Thanks for making me a collaborator. I'll help out as I can, even if it's just keeping an eye out on GitHub for things like this.