search

paulocheque / django-dynamic-fixture

A complete library to create dynamic model instances for testing purposes.
http://django-dynamic-fixture.readthedocs.io/
Other
391 stars 67 forks source link

Correct type for TimeField #139

Closed MrWeeble closed 3 years ago

MrWeeble commented 3 years ago

When creating a fixture for a TimeField the return should be a datetime.time instance rather than a datetime.datetime instance as currently

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling 4b877e021cd55ef3028b4e33a2137a496b92824c on MrWeeble:bug/timefield_should_return_time_not_datetime into dc4d49d7209ec73b636f1fbae99c90df7d99afc1 on paulocheque:master.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling 4b877e021cd55ef3028b4e33a2137a496b92824c on MrWeeble:bug/timefield_should_return_time_not_datetime into dc4d49d7209ec73b636f1fbae99c90df7d99afc1 on paulocheque:master.

MrWeeble commented 3 years ago

Anything I can do to expedite getting this merged? Would be good to get it into a release at some point

JanMalte commented 3 years ago

This MR looks good to me. This would make the field value to be in line with django: https://docs.djangoproject.com/en/3.2/ref/models/fields/#timefield

I'm not sure if this should just be a bugfix release of a major release, as the fixture value type would change after updating. What do you think?

paulocheque commented 3 years ago

Nice! I suppose we can generate a bufix release soon.