search

paulocheque / django-dynamic-fixture

A complete library to create dynamic model instances for testing purposes.
http://django-dynamic-fixture.readthedocs.io/
Other
391 stars 67 forks source link

[update] Ensure models are only created when running tests #18

Closed michaelmior closed 11 years ago

michaelmior commented 11 years ago

As discussed in #16

paulocheque commented 11 years ago

Great! I will review that and accept this pull request. Nice! Thanks! Regards

michaelmior commented 11 years ago

No problem. I happened to be reading over the django_nose documentation for another project and saw this option. Makes things much simpler :)

paulocheque commented 11 years ago

This commit broke tests in Travis. I can not reproduce the error locally yet. If you have any ideas to fix it.. check the runtests.py file. Thanks

michaelmior commented 11 years ago

I'll fire up Travis on my fork and check it out this evening.

paulocheque commented 11 years ago

It may be a bug in django-nose: https://github.com/jbalogh/django-nose/issues/15 If I resolved this issue I will post a comment here. Thanks!

michaelmior commented 11 years ago

That bug looks promising. I'll hold off on investigating now then until you have a chance to check that out :)

paulocheque commented 11 years ago

Fixed. I create a particular settings to adjust this, because django-nose, django, travis and scripts are creating a useless layer of complexity.

michaelmior commented 11 years ago

Great! Glad you have it fixed :)