Fixed Bug in Nose Plugin

paulocheque / django-dynamic-fixture

A complete library to create dynamic model instances for testing purposes.

http://django-dynamic-fixture.readthedocs.io/

Other

390 stars 67 forks source link

Fixed Bug in Nose Plugin #45

Closed clintonb closed 10 years ago

clintonb commented 10 years ago

Plugin disabled by default.
Plugin will only attempt to import Django libraries if the plugin is enabled.

Fixes #44

paulocheque commented 10 years ago

Hi, thanks for the PR.

What is the bug?

I thought the import attempt awesome, but I am not sure about changing the enabled to False as the default behavior.

clintonb commented 10 years ago

The problem occurs when I want to use nose for non-Django tests (#44). Nose loads the plugin file and immediately attempts to load Django. Since I don't have/need Django for my UI tests, the plugin loading fails and the tests never run.

The nose plugin documentation states that plugins "Plugins should not be enabled by default."

paulocheque commented 10 years ago

Amazing! Thanks!