search

paulocheque / django-dynamic-fixture

A complete library to create dynamic model instances for testing purposes.
http://django-dynamic-fixture.readthedocs.io/
Other
390 stars 67 forks source link

Towards fixing #5 #6

Closed tobych closed 12 years ago

tobych commented 12 years ago

This won't cover all cases; just integer defaults. You're allowed other types as a PK, and the code should really check that it's not being assigned exactly what it needs, perhaps, rather than checking that data is in a specified set.

travisbot commented 12 years ago

This pull request passes (merged ca93e4d8 into 84f9f72e).

travisbot commented 12 years ago

This pull request passes (merged 2b605084 into 84f9f72e).

paulocheque commented 12 years ago

Nice, I will think more about it and think about tests after accepting this pull request, ok?

Thanks for reporting again!

tobych commented 12 years ago

Sure. Do let me know if there's anything I can do to help move this forward. We're keen to have this feature upstream rather than continuing to maintain my fork. We love DDF! :-)

travisbot commented 12 years ago

This pull request passes (merged 99822345 into 84f9f72e).