search

paulocheque / django-dynamic-fixture

A complete library to create dynamic model instances for testing purposes.
http://django-dynamic-fixture.readthedocs.io/
Other
391 stars 67 forks source link

Update tox version and configuration. #60

Closed mrmachine closed 9 years ago

mrmachine commented 9 years ago
landscape-bot commented 9 years ago

Code Health Repository health increased by 2% when pulling ebcf2df on ixc:ixc/simplified-tox-ini into f5f7207 on paulocheque:master.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.08%) to 79.79% when pulling ebcf2df93cb64f5229ae6345aadbe289a9436750 on ixc:ixc/simplified-tox-ini into f5f72077eef6fcdc2113e332561fe5118aa4c85f on paulocheque:master.

landscape-bot commented 9 years ago

Code Health Repository health increased by 2% when pulling ee837ce on ixc:ixc/simplified-tox-ini into f5f7207 on paulocheque:master.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.08%) to 79.79% when pulling ee837ce5d14373d01f5eacc37081345ce3d4373f on ixc:ixc/simplified-tox-ini into f5f72077eef6fcdc2113e332561fe5118aa4c85f on paulocheque:master.

mrmachine commented 9 years ago

I didn't see pypy mentioned in the Django release notes, and I couldn't get the tests to pass with pypy even before making any changes to DDF. But that could just be my pypy setup, so feel free to add it back in.

envlist =
    django14-py{26,27},
    django16-py{26,27,32,33,pypy},
    django17-py{27,32,33,34,pypy},

basepython=
    py26: python2.6
    py27: python2.7
    py32: python3.2
    py33: python3.3
    py34: python3.4
    pypy: pypy
landscape-bot commented 9 years ago

Code Health Repository health increased by 2% when pulling 4087596 on ixc:ixc/simplified-tox-ini into f5f7207 on paulocheque:master.

mrmachine commented 9 years ago

I've updated the failing PyPy test to pass, but I'm not sure if the failure was a test error or a code error. Also testing old/unsupported versions of Django again and PyPy. Up to you if you want to leave them in or remove them.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 79.87% when pulling 40875962ec316c0e06352fec15db664ef8cd2c48 on ixc:ixc/simplified-tox-ini into f5f72077eef6fcdc2113e332561fe5118aa4c85f on paulocheque:master.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 79.87% when pulling 40875962ec316c0e06352fec15db664ef8cd2c48 on ixc:ixc/simplified-tox-ini into f5f72077eef6fcdc2113e332561fe5118aa4c85f on paulocheque:master.

mrmachine commented 9 years ago

It seems to be failing on Travis CI now with PyPy, but works for me locally with PyPy, so I'm not sure what's going on with that BadDataError. Maybe it needs to catch either error_msg or error_msg2 for PyPy.

landscape-bot commented 9 years ago

Code Health Repository health increased by 2% when pulling 239b6cd on ixc:ixc/simplified-tox-ini into f5f7207 on paulocheque:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.01%) to 79.88% when pulling 239b6cd07baee92a138d02a084c807424bd18d20 on ixc:ixc/simplified-tox-ini into f5f72077eef6fcdc2113e332561fe5118aa4c85f on paulocheque:master.

paulocheque commented 9 years ago

I will close this PR, but I changed the code thanks for your commit. I put a link to this PR in the commit message: https://github.com/paulocheque/django-dynamic-fixture/commit/4b09bfdd9155f7050fa21b779c256011e46eeccf

Thanks!

mrmachine commented 9 years ago

Thanks for merging. I noticed you are still not testing Python 2.6 and 3.2 (and subsequently don't need the u'' fixes for 3.2). I think those versions of Python are officially supported by Django (2.6 for 1.4-1.6 and 3.2 for 1.5-1.8), so I'm just curious about why you don't want to test against them as well?

paulocheque commented 9 years ago

Oh, actually, I got the idea for your comments. Now Python2.7 is the default python in most Linux distributions, so I believe the cost to use Python2.7 instead of Python2.6 is very low.

About 3.2, it is a very distinct version of Python that break compatibility badly with older versions. For that reason 3.3 and 3.4 fix the 3.2 "errors" of compatibility. For that reason I believe this version should be avoided.

In general, I believe Python community should incentivate Python2.7 and Python3.4 versions specially.

What do you think about it?

Do you use which Python?

mrmachine commented 9 years ago

I don't disagree that 2.6 and 3.2 are probably not very often used anymore, however, I think that if supported versions of Django support those versions of Python, then DDF should as well. I believe Ubuntu 12.04 LTS still using Python 3.2, and Ubuntu 10.04 LTS which only recently reached EOL was probably using Python 2.6. For some users they are just stuck with whatever version their distribution ships with, so they can get security updates. If the changes for DDF to support those versions are not a major effort, then I would try to include them.

paulocheque commented 9 years ago

Ok, great! So, do you think it is easy to create a clean pull request, to avoid merge problems with the tox.ini file? The changes of tox.ini would be basically add 26 and 32 versions. And you have already done the hard work to change the python strings too.

mrmachine commented 9 years ago

Done. See #64