search

paulodiovani / hacktoberrank

Hacktoberfest Rank
https://hacktoberrank-challenge.herokuapp.com/
MIT License
6 stars 17 forks source link

Apply recommended community standards. #11

Closed paulodiovani closed 4 years ago

paulodiovani commented 4 years ago

Github checklist for recommended community standards.

https://github.com/paulodiovani/hacktoberrank/community.

Open Pull requests accordingly.

geektutor commented 4 years ago

https://github.com/paulodiovani/hacktoberrank/pull/13

paulodiovani commented 4 years ago

There are still a few missing files to have all checks at https://github.com/paulodiovani/hacktoberrank/community. I'll add some suggestions here.

Contributing

:+1: :tada: First off, thanks for taking the time to contribute! :tada: :+1:

When contributing to this repository, please first discuss the change you wish to make via issue, email, or any other method with the owners and former collaborators of this repository before making a change.

The Issues section is a good start to check what is needed. Alternatively, you can contribute with small changes, refactoring or improvements that don't have a related issue, in these cases you can just open a pull request.

Please note we have a code of conduct, please follow it in all your interactions with the project. You can read the code of conduct at https://github.com/paulodiovani/hacktoberrank/blob/master/CODE_OF_CONDUCT.md.

Pull Request Process

  1. Add a description about what the pull request changes or fixes
  2. Ensure the pull request branch can be run following the instructions on README and won't break build and tests in CI.
  3. Write unit tests for new features.
  4. New e2e tests are also welcome but can be written on a separate PR.
  5. Update the README.md with details of changes, if any, including setup/run instructions, interface, etc.
  6. Be kind when discussing changes on pull requests.
  7. Pull Requests are required to be approved at least once to be merged. This process can take a while so be patient.

Other ways of contributing

Pull request template

Detailed changes description... What this PRs adds or improve in the project.

Is this related to an issue?

Issue #[number] or link.

How to run and see the changes?

  1. Clone this pull request branch
  2. Follow setup instructions on README
  3. Additional steps...

Do we have any screenshots?

screnshot 001

paulodiovani commented 4 years ago

review and suggestions, please: https://github.com/paulodiovani/hacktoberrank/pull/24

arabyalhomsi commented 4 years ago

Can we have the coverage report tag? the one that says how much code we covered in our tests?

paulodiovani commented 4 years ago

Can we have the coverage report tag? the one that says how much code we covered in our tests?

Good idea. :)