paulodiovani / hacktoberrank

Hacktoberfest Rank
https://hacktoberrank-challenge.herokuapp.com/
MIT License
6 stars 17 forks source link

Serve front-end dist from express app #34

Closed arabyalhomsi closed 4 years ago

arabyalhomsi commented 4 years ago

https://github.com/paulodiovani/hacktoberrank/issues/30

arabyalhomsi commented 4 years ago

npm run build needs to be changed in Travis

paulodiovani commented 4 years ago

We must also update README.md, adding:

paulodiovani commented 4 years ago

Hey @arabyalhomsi , We have just a couple more days to finish the challenge. Do you have some time for this? :running_man:

arabyalhomsi commented 4 years ago

@paulodiovani I'll try to do it now

arabyalhomsi commented 4 years ago

I do not understand where this conflict is coming from

arabyalhomsi commented 4 years ago

There is no merge conflicts in my local repo, I just do not get why there is conflict

paulodiovani commented 4 years ago

because upstream has more recent commits, you can do this:

# add original repo as upstream 
git remote add upstream https://github.com/paulodiovani/hacktoberrank.git

# sync your local master branch with upstream
# this is a good idea to do always before starting a new branch/PR
git fetch upstream
git checkout master
git merge upstream/master

# now, just sync your feature branch and fix conflicts normally
git checkout feature/serve-front-from-back
git merge master  # and so on...
arabyalhomsi commented 4 years ago

My filesystem is acting really weird. I am not sure how to fix it and I do not have that much time unfortunately

paulodiovani commented 4 years ago

@arabyalhomsi you explicit changed file modes in these two commits.

Files should have 0644 mode, unless they are executable (bin) files.

Could you please revert these commits at least?

Also, the .env was commited, it should not.

paulodiovani commented 4 years ago

I'll do this by command line.